8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

[SoniaZaldana]

Hi all,

This pull request contains a backport of 43c6f0b5880899b797fab2f851bd35be1c342439.

Testing:

• Modified test case passes.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326591 needs maintainer approval

Issue

• JDK-8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/393/head:pull/393
$ git checkout pull/393

Update a local copy of the PR:
$ git checkout pull/393
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 393

View PR using the GUI difftool:
$ git pr show -t 393

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/393.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into pr/378 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (2a6020e4)
• 01: Full - Incremental (d8d1a588)
• 00: Full (d8d1a588)

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8326591: The approval request has been approved.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout my-backport-8326591
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version 2a6020e) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 7d4a6fc.

[openjdk]

@jerboaa @SoniaZaldana Pushed as commit 7d4a6fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.