Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320807: [PPC64][ZGC] C1 generates wrong code for atomics #4

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 13, 2023

Backport of JDK-8320807.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320807 needs maintainer approval

Issue

  • JDK-8320807: [PPC64][ZGC] C1 generates wrong code for atomics (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/4/head:pull/4
$ git checkout pull/4

Update a local copy of the PR:
$ git checkout pull/4
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/4/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4

View PR using the GUI difftool:
$ git pr show -t 4

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/4.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3087e14cde9257680f0406b11942f9cb7739cb7b 8320807: [PPC64][ZGC] C1 generates wrong code for atomics Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK21 is affected by this Generational ZGC bug. Fix applies cleanly and has been tested for 2 weeks in head. Retested in JDK21u-dev. Only touches PPC64 files.

@TheRealMDoerr
Copy link
Contributor Author

Pre-submit test failures are unrelated. This PR only touches PPC64 files.

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@TheRealMDoerr
8320807: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320807: [PPC64][ZGC] C1 generates wrong code for atomics

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • fb34573: 8321894: Bump update version for OpenJDK: 21.0.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 14, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

Going to push as commit 0106db0.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 0e0e897: 8320898: exclude compiler/vectorapi/reshape/TestVectorReinterpret.java on ppc64(le) platforms
  • fb34573: 8321894: Bump update version for OpenJDK: 21.0.3

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2023
@openjdk openjdk bot closed this Dec 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@TheRealMDoerr Pushed as commit 0106db0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the backport-TheRealMDoerr-3087e14c branch December 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant