Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319648: java/lang/SecurityManager tests ignore vm flags #402

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 23, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319648 needs maintainer approval

Issue

  • JDK-8319648: java/lang/SecurityManager tests ignore vm flags (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/402/head:pull/402
$ git checkout pull/402

Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 402

View PR using the GUI difftool:
$ git pr show -t 402

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/402.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 23, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319648: java/lang/SecurityManager tests ignore vm flags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 7d4a6fc: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used
  • 3050bf3: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols
  • 5694ad2: 8303972: (zipfs) Make test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java independent of the zip command line
  • 39f7178: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
  • 8c6e32d: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 437cf354e2d1f7df79fa32265ccf86a0e84257b5 8319648: java/lang/SecurityManager tests ignore vm flags Mar 23, 2024
@openjdk
Copy link

openjdk bot commented Mar 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 25, 2024

GHA failure Risc-V compile setup problem. Unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 25, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 660c00a.
Since your change was applied there have been 17 commits pushed to the master branch:

  • bb2ddc0: 8326948: Force English locale for timeout formatting
  • aa1fe7a: 8326824: Test: remove redundant test in compiler/vectorapi/reshape/utils/TestCastMethods.java
  • 1dfda33: 8319651: Several network tests ignore vm flags when start java process
  • 2836734: 8324236: compiler/ciReplay/TestInliningProtectionDomain.java failed with RuntimeException: should only dump inline information for ... expected true, was false
  • 098656d: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless
  • 438c41a: 8328705: GHA: Cross-compilation jobs do not require build JDK
  • dbb3dfd: 8322858: compiler/c2/aarch64/TestFarJump.java fails on AArch64 due to unexpected PrintAssembly output
  • d59d00d: 8319647: Few java/lang/System/LoggerFinder/modules tests ignore vm flags
  • 998ba93: 8319567: Update java/lang/invoke tests to support vm flags
  • bb8b646: 8319574: Exec/process tests should be marked as flagless
  • ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/77d6dfd854f3322a0cd5c89a7d96393703a918eb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@GoeLin Pushed as commit 660c00a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant