Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 #408

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 25, 2024

Fixes a recent GHA regression.

Additional testing:

  • GHA, first run passes cross-builds
  • GHA, second run passes cross-builds

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328948 needs maintainer approval

Issue

  • JDK-8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 (Bug - P1 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/408/head:pull/408
$ git checkout pull/408

Update a local copy of the PR:
$ git checkout pull/408
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 408

View PR using the GUI difftool:
$ git pr show -t 408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/408.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 447436e18c754424a62af5135fb3a8973564091d 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960 Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Fixes a recent GHA regression. Applies cleanly. Both first and second GHA runs run cross-compiled builds well. Product risk is low, the fix is in GHA.

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@shipilev
8328948: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 25, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

Going to push as commit a2557bb.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2024
@openjdk openjdk bot closed this Mar 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@shipilev Pushed as commit a2557bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant