Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313710: jcmd: typo in the documentation of JFR.start and JFR.dump #410

Closed
wants to merge 2 commits into from

Conversation

kurashige23
Copy link
Contributor

@kurashige23 kurashige23 commented Mar 26, 2024

Hi all,

I'd like to backport JDK-8313710 to jdk21u-dev.

I confirmed that the fixes are reflected in the documentation and that all of the jdk_jfr tests passed.

Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313710 needs maintainer approval

Issue

  • JDK-8313710: jcmd: typo in the documentation of JFR.start and JFR.dump (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/410/head:pull/410
$ git checkout pull/410

Update a local copy of the PR:
$ git checkout pull/410
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 410

View PR using the GUI difftool:
$ git pr show -t 410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/410.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2024

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@kurashige23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e3f3647: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
  • f2a013b: 8328825: Google CAInterop test failures
  • a2557bb: 8328948: GHA: Restoring sysroot from cache skips the build after JDK-8326960

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 16d917a85f9311611a14a63f1e53afae970efc73 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Mar 26, 2024
@openjdk
Copy link

openjdk bot commented Mar 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 26, 2024

Webrevs

@kurashige23
Copy link
Contributor Author

/approval request Clean backport. Fix about typo and indent in the documentation only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 26, 2024

@kurashige23
8313710: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 26, 2024
@kurashige23
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@kurashige23
Your change (at version 11328d1) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Apr 2, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 4c7b1d9.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0bbb803: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • f5dfd8b: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
  • d17aa5e: 8319437: NMT should show library names in call stacks
  • 2800d8b: 8326643: JDK server does not send a dummy change_cipher_spec record after HelloRetryRequest message
  • 245de59: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException
  • 6791646: 8328812: Update and move siphash license
  • c263bc5: 8327998: Enable java/lang/ProcessBuilder/JspawnhelperProtocol.java on Mac
  • 0bfb53c: 8323994: gtest runner repeats test name for every single gtest assertion
  • 7751996: 8326661: sun/java2d/cmm/ColorConvertOp/ColConvTest.java assumes profiles were generated by LCMS
  • e3f3647: 8280056: gtest/LargePageGtests.java#use-large-pages failed "os.release_one_mapping_multi_commits_vm"
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/c33815ad3c86bd38432f80877c0bc1ac1af15070...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev @kurashige23 Pushed as commit 4c7b1d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants