Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" #419

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 28, 2024

Hi,

Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

image

Thanks,
-sendao


Progress

  • JDK-8321925 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/419/head:pull/419
$ git checkout pull/419

Update a local copy of the PR:
$ git checkout pull/419
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 419

View PR using the GUI difftool:
$ git pr show -t 419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/419.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b6233c3de773fb57b23704f1fec05d8b2d9c11c0 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist" Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2024

Webrevs

@openjdk openjdk bot added the approval label Apr 7, 2024
@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

@openjdk
Copy link

openjdk bot commented Apr 7, 2024

@sendaoYan
8321925: The approval request has been created successfully.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 9, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi,
/approval request Clean backport of JDK-8321925. Only change the testcase, the change has been verified, the risk is low.

@openjdk
Copy link

openjdk bot commented May 9, 2024

@sendaoYan
8321925: Approval has already been requested and approved.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@sendaoYan
Your change (at version 4fdd7c8) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2024

@sendaoYan
Your change (at version 4fdd7c8) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit bddd6a7.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2024
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr @sendaoYan Pushed as commit bddd6a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants