Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" #423

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 28, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317965 needs maintainer approval

Issue

  • JDK-8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/423/head:pull/423
$ git checkout pull/423

Update a local copy of the PR:
$ git checkout pull/423
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 423

View PR using the GUI difftool:
$ git pr show -t 423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/423.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 5207443b360cfe3ee9c53ece55da3464c13f6a9f 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" Mar 28, 2024
@openjdk
Copy link

openjdk bot commented Mar 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 30, 2024

GHA failure: RuntimeException: Unable to load b.jar.
Probably caused by this PR, need to check.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2024

Closing this and making a new PR which also includes 8317965 which will solve the GHA issue.

@GoeLin GoeLin closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
1 participant