Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" #434

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 2, 2024

I backport this for parity with 21.0.4-oracle.

Includes two changes. Else GHA show failures.
Both are clean backports, will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319265 needs maintainer approval
  • JDK-8317965 needs maintainer approval

Issues

  • JDK-8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" (Bug - P4 - Approved)
  • JDK-8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar" (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/434/head:pull/434
$ git checkout pull/434

Update a local copy of the PR:
$ git checkout pull/434
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/434/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 434

View PR using the GUI difftool:
$ git pr show -t 434

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/434.diff

Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8317965 8319265 Backport 5207443b360cfe3ee9c53ece55da3464c13f6a9f Apr 2, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false"
8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9e6fb82: 8328592: hprof tests fail with -XX:-CompactStrings
  • 342ae64: 8319876: Reduce memory consumption of VM_ThreadDump::doit
  • 4c7b1d9: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
  • 0bbb803: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • f5dfd8b: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
  • d17aa5e: 8319437: NMT should show library names in call stacks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5207443b360cfe3ee9c53ece55da3464c13f6a9f 8317965: TestLoadLibraryDeadlock.java fails with "Unable to load native library.: expected true, was false" Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 2, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2024

/issue 8319265

@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2024

/clean

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@GoeLin
Adding additional issue to issue list: 8319265: TestLoadLibraryDeadlock.java fails on windows-x64 "Unable to load b.jar".

@openjdk openjdk bot added the clean label Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 3, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit 620250b.
Since your change was applied there have been 16 commits pushed to the master branch:

  • d2c6be9: 8317350: Move code cache purging out of CodeCache::UnloadingScope
  • c094d7e: 8317677: Specialize Vtablestubs::entry_for() for VtableBlob
  • 0839687: 8317235: Remove Access API use in nmethod class
  • 32ab4a2: 8316669: ImmutableOopMapSet destructor not called
  • 7c5ff9a: 8316670: Remove effectively unused nmethodBucket::_count
  • 92b237c: 8315485: (fs) Move java/nio/file/Path/Misc.java tests into java/nio/file/Path/PathOps.java
  • 618a7ba: 8315998: Remove dead ClassLoaderDataGraphKlassIteratorStatic
  • 8d3151f: 8316002: Remove unnecessary seen_dead_loader in ClassLoaderDataGraph::do_unloading
  • fa5cc58: 8315605: G1: Add number of nmethods in code roots scanning statistics
  • 80cf08a: 8294985: SSLEngine throws IAE during parsing of X500Principal
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/2800d8bc708f7ccdf32ef64c52f99f40b1459698...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@GoeLin Pushed as commit 620250b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8317965_8319265 branch April 3, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant