Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328589: unify os::breakpoint among posix platforms #448

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 4, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328589 needs maintainer approval

Issue

  • JDK-8328589: unify os::breakpoint among posix platforms (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/448/head:pull/448
$ git checkout pull/448

Update a local copy of the PR:
$ git checkout pull/448
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 448

View PR using the GUI difftool:
$ git pr show -t 448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/448.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328589: unify os::breakpoint among posix platforms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 807f21d: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 1825464: 8329823: RISC-V: Need to sync CPU features with related JVM flags
  • db750ff: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
  • dc53669: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • db8ea85: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
  • d1caa3f: 8313899: JVMCI exception Translation can fail in TranslatedException.
  • c993c0c: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • fbb424f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • ba4ad2b: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • fb10dd9: 8281658: Add a security category to the java -XshowSettings option
  • ... and 30 more: https://git.openjdk.org/jdk21u-dev/compare/78e35ea113bed4a5f66225836c887a45696bbf44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 93d1700f23d42cb35b6028c5d7d029c035711acf 8328589: unify os::breakpoint among posix platforms Apr 4, 2024
@openjdk
Copy link

openjdk bot commented Apr 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2024

Webrevs

@openjdk openjdk bot added the approval label Apr 4, 2024
@GoeLin
Copy link
Member

GoeLin commented Apr 12, 2024

What's up with GHA?

@MBaesken
Copy link
Member Author

MBaesken commented Apr 12, 2024

It just says 'this Job failed' ; cannot get more info out of the logs linked below. Sorry in the current state this GHA stuff is not of much help !

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 15, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

Going to push as commit eec41a4.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 807f21d: 8329545: [s390x] Fix garbage value being passed in Argument Register
  • 1825464: 8329823: RISC-V: Need to sync CPU features with related JVM flags
  • db750ff: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
  • dc53669: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
  • db8ea85: 8303959: tools/jpackage/share/RuntimePackageTest.java fails with java.lang.AssertionError missing files
  • d1caa3f: 8313899: JVMCI exception Translation can fail in TranslatedException.
  • c993c0c: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • fbb424f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • ba4ad2b: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • fb10dd9: 8281658: Add a security category to the java -XshowSettings option
  • ... and 30 more: https://git.openjdk.org/jdk21u-dev/compare/78e35ea113bed4a5f66225836c887a45696bbf44...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 15, 2024
@openjdk openjdk bot closed this Apr 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2024
@openjdk
Copy link

openjdk bot commented Apr 15, 2024

@MBaesken Pushed as commit eec41a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants