8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR contains a backport of commit openjdk/jdk@4018b2b.
I'd like to do the backport because jdk 21 is affected by the issue. The included test hangs without the change.
Besides it will reduce the noise in jck tests we're doing regularily (the test api/java_net/ServerSocket/AcceptInterruptibleTests_PlatformThreads fails sometimes because of the issue).
The original fix does not apply due to renamig of a local variable. Also the context differs because there's no
postInterrupt
method to be called.Nevertheless I'd consider the risk low because of the small size of the fix.
Tested with the included test.
The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/451/head:pull/451
$ git checkout pull/451
Update a local copy of the PR:
$ git checkout pull/451
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/451/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 451
View PR using the GUI difftool:
$ git pr show -t 451
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/451.diff
Webrev
Link to Webrev Comment