Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319955: Improve dependencies removal during class unloading #456

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 5, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319955 needs maintainer approval

Issue

  • JDK-8319955: Improve dependencies removal during class unloading (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/456/head:pull/456
$ git checkout pull/456

Update a local copy of the PR:
$ git checkout pull/456
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 456

View PR using the GUI difftool:
$ git pr show -t 456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/456.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319955: Improve dependencies removal during class unloading

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 249d896: 8328702: C2: Crash during parsing because sub type check is not folded
  • 6f60957: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
  • c254aff: 8321718: ProcessTools.executeProcess calls waitFor before logging
  • 38a2173: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
  • e0d2248: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
  • 8173c64: 8329570: G1: Excessive is_obj_dead_cond calls in verification
  • e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 88abc6a: 8328604: remove on_aix() function
  • fd50739: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • d5f44dc: 8319650: Improve heap dump performance with class metadata caching
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fbe19378c38decaff221f6570d1b78bb801a5e5d 8319955: Improve dependencies removal during class unloading Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 6, 2024

/reviewers 1

@openjdk
Copy link

openjdk bot commented Apr 6, 2024

@GoeLin
Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@jerboaa
Copy link
Contributor

jerboaa commented Apr 8, 2024

@tstuefe Could you please help review this backport? Thanks!

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay. Original patch was also reviewed by Erik Oe and David.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 10, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

Going to push as commit 7c63791.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 2a3c4fc: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
  • 5a94e48: 8317600: VtableStubs::stub_containing() table load not ordered wrt to stores
  • 41c8606: 8316959: Improve InlineCacheBuffer pending queue management
  • f341621: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
  • e63addb: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
  • 686399a: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 6c5500b: 8318986: Improve GenericWaitBarrier performance
  • f0f2e70: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
  • 7743b6c: Merge
  • 05f18b1: 8329838: [21u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 21.0.3
  • ... and 45 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2024
@openjdk openjdk bot closed this Apr 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@GoeLin Pushed as commit 7c63791.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants