Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325203: System.exit(0) kills the launched 3rd party application #459

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 5, 2024

I backport this for parity with 21.0.4-oracle.
Resolved Copyright, will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325203 needs maintainer approval

Issue

  • JDK-8325203: System.exit(0) kills the launched 3rd party application (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/459/head:pull/459
$ git checkout pull/459

Update a local copy of the PR:
$ git checkout pull/459
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 459

View PR using the GUI difftool:
$ git pr show -t 459

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/459.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325203: System.exit(0) kills the launched 3rd party application

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6944537c3ebbbb638479e4c2b90a71ad5869023c 8325203: System.exit(0) kills the launched 3rd party application Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 5, 2024

/clean

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@GoeLin This backport pull request is already marked as clean

@GoeLin
Copy link
Member Author

GoeLin commented Apr 6, 2024

GHA: many failures, infra related. We saw this with several PRs lately. Restarting the tests.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 8, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

Going to push as commit b9ca253.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1c4479f: 8325567: jspawnhelper without args fails with segfault

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024
@openjdk openjdk bot closed this Apr 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@GoeLin Pushed as commit b9ca253.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr
Copy link
Contributor

/backport jdk17u-dev

@openjdk
Copy link

openjdk bot commented May 28, 2024

@TheRealMDoerr the backport was successfully created on the branch backport-TheRealMDoerr-b9ca2532 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b9ca2532 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 8 Apr 2024 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-TheRealMDoerr-b9ca2532:backport-TheRealMDoerr-b9ca2532
$ git checkout backport-TheRealMDoerr-b9ca2532
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-TheRealMDoerr-b9ca2532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants