Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time #460

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 5, 2024

I backport this for parity with 21.0.4-oracle.

Ran manual test on win and linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311881 needs maintainer approval

Issue

  • JDK-8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/460/head:pull/460
$ git checkout pull/460

Update a local copy of the PR:
$ git checkout pull/460
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 460

View PR using the GUI difftool:
$ git pr show -t 460

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/460.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • d5f44dc: 8319650: Improve heap dump performance with class metadata caching
  • b9ca253: 8325203: System.exit(0) kills the launched 3rd party application
  • 1c4479f: 8325567: jspawnhelper without args fails with segfault
  • 35f291b: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
  • 2a56bfb: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
  • d5c170a: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
  • e5ee283: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • 3b3ec13: 8314975: JavadocTester should set source path if not specified
  • e5c1031: 8293069: Make -XX:+Verbose less verbose
  • 8ed46c2: 8294699: Launcher causes lingering busy cursor
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 197981b431fb7c7e6740ac45a671b99d1c7583c6 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 6, 2024

GHA variaous failrues, surely infra related. As this is a test change and needs manual test execution, I proceed without restarteing GHA. It would not be tested by GHA anyways.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 10, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

Going to push as commit e0d2248.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 8173c64: 8329570: G1: Excessive is_obj_dead_cond calls in verification
  • e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • 88abc6a: 8328604: remove on_aix() function
  • fd50739: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • d5f44dc: 8319650: Improve heap dump performance with class metadata caching
  • b9ca253: 8325203: System.exit(0) kills the launched 3rd party application
  • 1c4479f: 8325567: jspawnhelper without args fails with segfault
  • 35f291b: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
  • 2a56bfb: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
  • d5c170a: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
  • ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2024
@openjdk openjdk bot closed this Apr 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@GoeLin Pushed as commit e0d2248.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant