Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314975: JavadocTester should set source path if not specified #461

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 5, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314975 needs maintainer approval

Issue

  • JDK-8314975: JavadocTester should set source path if not specified (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/461/head:pull/461
$ git checkout pull/461

Update a local copy of the PR:
$ git checkout pull/461
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 461

View PR using the GUI difftool:
$ git pr show -t 461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/461.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314975: JavadocTester should set source path if not specified

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 8ed46c2: 8294699: Launcher causes lingering busy cursor
  • e1f8f83: 8316460: 4 javax/management tests ignore VM flags
  • 85ca789: 8318962: Update ProcessTools javadoc with suggestions in 8315097
  • 40b1c4b: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12
  • ccaa6d7: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2f4d601a56bf02db2766d1f8a2ddfff906b78678 8314975: JavadocTester should set source path if not specified Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 5, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 5, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

Going to push as commit 3b3ec13.
Since your change was applied there have been 6 commits pushed to the master branch:

  • e5c1031: 8293069: Make -XX:+Verbose less verbose
  • 8ed46c2: 8294699: Launcher causes lingering busy cursor
  • e1f8f83: 8316460: 4 javax/management tests ignore VM flags
  • 85ca789: 8318962: Update ProcessTools javadoc with suggestions in 8315097
  • 40b1c4b: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12
  • ccaa6d7: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 8, 2024
@openjdk openjdk bot closed this Apr 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@GoeLin Pushed as commit 3b3ec13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant