8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

[RealCLanger]

Hi all,

This pull request contains a backport of JDK-8325579, commit 92d6fa4a from the openjdk/jdk22u repository.

The commit being backported was authored by Christoph Langer on 5 Apr 2024 and had no reviewers.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325579 needs maintainer approval
• Change requires CSR request JDK-8326482 to be approved

Issues

• JDK-8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (Bug - P3 - Approved)
• JDK-8326482: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/466/head:pull/466
$ git checkout pull/466

Update a local copy of the PR:
$ git checkout pull/466
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 466

View PR using the GUI difftool:
$ git pr show -t 466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/466.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• fb10dd9: 8281658: Add a security category to the java -XshowSettings option
• 249d896: 8328702: C2: Crash during parsing because sub type check is not folded
• 6f60957: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
• c254aff: 8321718: ProcessTools.executeProcess calls waitFor before logging
• 38a2173: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
• e0d2248: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
• 8173c64: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• 88abc6a: 8328604: remove on_aix() function
• fd50739: 8315652: RISC-V: Features string uses wrong separator for jtreg
• ... and 14 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (f15225e7)

[RealCLanger]

/integrate

[openjdk]

Going to push as commit fbb424f.
Since your change was applied there have been 25 commits pushed to the master branch:

• ba4ad2b: 8316608: Enable parallelism in vmTestbase/gc/vector tests
• fb10dd9: 8281658: Add a security category to the java -XshowSettings option
• 249d896: 8328702: C2: Crash during parsing because sub type check is not folded
• 6f60957: 8328037: Test java/util/Formatter/Padding.java has unnecessary high heap requirement after JDK-8326718
• c254aff: 8321718: ProcessTools.executeProcess calls waitFor before logging
• 38a2173: 8318585: Rename CodeCache::UnloadingScope to UnlinkingScope
• e0d2248: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
• 8173c64: 8329570: G1: Excessive is_obj_dead_cond calls in verification
• e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• 88abc6a: 8328604: remove on_aix() function
• ... and 15 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit fbb424f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.