Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315824: Open source several Swing Text/HTML related tests #468

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Apr 5, 2024

Hi all,

This pull request contains a backport of commit c11f8352 from the openjdk/jdk repository.

The commit being backported was authored by Harshitha Onkar on 14 Sep 2023 and was reviewed by Prasanta Sadhukhan and Alexander Zvegintsev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ This PR only contains changes already present in the target

Issue

  • JDK-8315824: Open source several Swing Text/HTML related tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/468/head:pull/468
$ git checkout pull/468

Update a local copy of the PR:
$ git checkout pull/468
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/468/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 468

View PR using the GUI difftool:
$ git pr show -t 468

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/468.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@SoniaZaldana This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport c11f8352e96a01b39e54080716030ec96f717cae 8315824: Open source several Swing Text/HTML related tests Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review April 8, 2024 15:16
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 21, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@SoniaZaldana
Your change (at version 5442f83) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@SoniaZaldana
Copy link
Member Author

Closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant