Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316154: Opensource JTextArea manual tests #469

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Apr 5, 2024

Hi all,

This pull request contains a backport of commit 33c62e4f from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 14 Sep 2023 and was reviewed by Abhishek Kumar and Jayathirth D V.

Thanks!


Progress

  • JDK-8316154 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316154: Opensource JTextArea manual tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/469/head:pull/469
$ git checkout pull/469

Update a local copy of the PR:
$ git checkout pull/469
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 469

View PR using the GUI difftool:
$ git pr show -t 469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/469.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 5, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 5, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316154: Opensource JTextArea manual tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 667513a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 515783b: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • 7c63791: 8319955: Improve dependencies removal during class unloading
  • 2a3c4fc: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
  • 5a94e48: 8317600: VtableStubs::stub_containing() table load not ordered wrt to stores
  • 41c8606: 8316959: Improve InlineCacheBuffer pending queue management
  • f341621: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
  • e63addb: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
  • 686399a: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 6c5500b: 8318986: Improve GenericWaitBarrier performance
  • ... and 48 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 33c62e4fffe33a7593fd0c01de53507bfd01dc3b 8316154: Opensource JTextArea manual tests Apr 5, 2024
@openjdk
Copy link

openjdk bot commented Apr 5, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review April 8, 2024 15:17
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2024

Webrevs

@amosshi
Copy link

amosshi commented Apr 21, 2024

SAP nightlies passed on 2024-04-16,19,20

@amosshi
Copy link

amosshi commented Apr 21, 2024

/approval request "Backporting for parity with 21.0.4-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-04-16,19,20”

@openjdk
Copy link

openjdk bot commented Apr 21, 2024

@amosshi Only the author (@SoniaZaldana) is allowed to issue the /approval command.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 21, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@SoniaZaldana
Your change (at version 4f97091) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit 1861655.
Since your change was applied there have been 71 commits pushed to the master branch:

  • a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
  • bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
  • ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
  • 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • b56b6f5: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 8e438ab: 8315824: Open source several Swing Text/HTML related tests
  • 1f43e2f: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
  • a6931db: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • af6c585: 8327474: Review use of java.io.tmpdir in jdk tests
  • ... and 61 more: https://git.openjdk.org/jdk21u-dev/compare/b80fb5e6d4c5fa5bd0df31ae2d52bd872880c16e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@shipilev @SoniaZaldana Pushed as commit 1861655.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants