8329570: G1: Excessive is_obj_dead_cond calls in verification

[shipilev]

Simple fastdebug performance improvement fix. Risk is low, as it only moves the assert to an earlier stage.

Additional testing:

• GHA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329570 needs maintainer approval

Issue

• JDK-8329570: G1: Excessive is_obj_dead_cond calls in verification (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/473/head:pull/473
$ git checkout pull/473

Update a local copy of the PR:
$ git checkout pull/473
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/473/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 473

View PR using the GUI difftool:
$ git pr show -t 473

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/473.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329570: G1: Excessive is_obj_dead_cond calls in verification

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• 88abc6a: 8328604: remove on_aix() function
• fd50739: 8315652: RISC-V: Features string uses wrong separator for jtreg
• d5f44dc: 8319650: Improve heap dump performance with class metadata caching
• b9ca253: 8325203: System.exit(0) kills the launched 3rd party application
• 1c4479f: 8325567: jspawnhelper without args fails with segfault
• 35f291b: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
• 2a56bfb: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
• d5c170a: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
• e5ee283: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
• ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/8ed46c2b0e8c5f440a7f079953ea51b1f9e0d41e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (1742a39a)

[shipilev]

This is actually a clean backport. Weird that bots are not marking it as such.

/clean

[shipilev]

/approval request Simple fastdebug performance improvement fix. GHA tests pass. Risk is low, as it only moves the assert to an earlier stage.

[openjdk]

@shipilev This backport pull request is now marked as clean

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@shipilev
8329570: The approval request has been created successfully.

[zhaosongzs]

This is actually a clean backport. Weird that bots are not marking it as such.

/clean

The bot didn't mark this pr as clean because the file name is different.
In the diff of this pr, the file name is heapRegion.cpp.
In the diff of the original commit, the file name is g1HeapRegion.cpp.

[shipilev]

The bot didn't mark this pr as clean because the file name is different. In the diff of this pr, the file name is heapRegion.cpp. In the diff of the original commit, the file name is g1HeapRegion.cpp.

Oh, that explains it, thanks!

[shipilev]

/integrate

[openjdk]

Going to push as commit 8173c64.
Since your change was applied there have been 12 commits pushed to the master branch:

• e95e6fe: 8305645: System Tray icons get corrupted when Windows primary monitor changes
• 88abc6a: 8328604: remove on_aix() function
• fd50739: 8315652: RISC-V: Features string uses wrong separator for jtreg
• d5f44dc: 8319650: Improve heap dump performance with class metadata caching
• b9ca253: 8325203: System.exit(0) kills the launched 3rd party application
• 1c4479f: 8325567: jspawnhelper without args fails with segfault
• 35f291b: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677
• 2a56bfb: 8316451: 6 java/lang/instrument/PremainClass tests ignore VM flags
• d5c170a: 8319578: Few java/lang/instrument ignore test.java.opts and accept test.vm.opts only
• e5ee283: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
• ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/8ed46c2b0e8c5f440a7f079953ea51b1f9e0d41e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 8173c64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.