Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323685: PrintSystemDictionaryAtExit has mutex rank assert #477

Closed
wants to merge 6 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 8, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323685 needs maintainer approval

Issue

  • JDK-8323685: PrintSystemDictionaryAtExit has mutex rank assert (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/477/head:pull/477
$ git checkout pull/477

Update a local copy of the PR:
$ git checkout pull/477
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 477

View PR using the GUI difftool:
$ git pr show -t 477

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/477.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/476 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 8, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323685: PrintSystemDictionaryAtExit has mutex rank assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2865afe759fd5362abd0947fd4c1f5c8d3519ca3 8323685: PrintSystemDictionaryAtExit has mutex rank assert Apr 8, 2024
@openjdk
Copy link

openjdk bot commented Apr 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Apr 8, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2024

Webrevs

@openjdk openjdk bot added approval and removed approval labels Apr 18, 2024
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/476 to master April 19, 2024 10:21
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8323685
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@GoeLin this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout goetz_backport_8323685
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Apr 19, 2024
@openjdk openjdk bot added clean ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Apr 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

Going to push as commit f341621.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2024
@openjdk openjdk bot closed this Apr 19, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 19, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@GoeLin Pushed as commit f341621.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8323685 branch April 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant