Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320924: Improve heap dump performance by optimizing archived object checks #479

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 9, 2024

Improves heap dump performance some more.

Additional testing:

  • MacOS AArch64 server release, heap dump performance improved
  • MacOS AArch64 server fastdebug, serviceability/ (contains heap dump tests)
  • MacOS AArch64 server fastdebug, runtime/ErrorHandling (contains heap dump on failure tests)
  • MacOS AArch64 server fastdebug, gc/epsilon (contains heap dump on failure tests)
  • MacOS AArch64 server fastdebug, sun/tools/jhsdb (contains heap dump tests)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320924 needs maintainer approval

Issue

  • JDK-8320924: Improve heap dump performance by optimizing archived object checks (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/479/head:pull/479
$ git checkout pull/479

Update a local copy of the PR:
$ git checkout pull/479
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/479/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 479

View PR using the GUI difftool:
$ git pr show -t 479

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/479.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320924: Improve heap dump performance by optimizing archived object checks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • 031acf1: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
  • 324cef1: 8327971: Multiple ASAN errors reported for metaspace
  • ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
  • febbf35: 8316242: Opensource SwingGraphics manual test
  • 1861655: 8316154: Opensource JTextArea manual tests
  • a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
  • bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
  • ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
  • 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • ... and 52 more: https://git.openjdk.org/jdk21u-dev/compare/d5f44dcae2f0be291e1ce52562574fccce7dc763...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f32ab8cc47c8a1b4887e9c7c86b145ce4b85c546 8320924: Improve heap dump performance by optimizing archived object checks Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 9, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2024

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Apr 9, 2024

/approval request Clean backport to further improve heap dump performance. Applies cleanly. Heap dump tests pass.

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@shipilev
8320924: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 9, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 25, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

Going to push as commit 9c0e18c.
Since your change was applied there have been 64 commits pushed to the master branch:

  • 41237fc: 8320707: Virtual thread test updates
  • 955fcc1: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest
  • 031acf1: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
  • 324cef1: 8327971: Multiple ASAN errors reported for metaspace
  • ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
  • febbf35: 8316242: Opensource SwingGraphics manual test
  • 1861655: 8316154: Opensource JTextArea manual tests
  • a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
  • bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
  • ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • ... and 54 more: https://git.openjdk.org/jdk21u-dev/compare/d5f44dcae2f0be291e1ce52562574fccce7dc763...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2024
@openjdk openjdk bot closed this Apr 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@shipilev Pushed as commit 9c0e18c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8320924-heapdump-archive-checks branch April 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant