Skip to content

8318322: Update IANA Language Subtag Registry to Version 2023-10-16#483

Closed
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8318322
Closed

8318322: Update IANA Language Subtag Registry to Version 2023-10-16#483
GoeLin wants to merge 3 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8318322

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 10, 2024

One of the required updates of meta information.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318322 needs maintainer approval

Issue

  • JDK-8318322: Update IANA Language Subtag Registry to Version 2023-10-16 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/483/head:pull/483
$ git checkout pull/483

Update a local copy of the PR:
$ git checkout pull/483
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/483/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 483

View PR using the GUI difftool:
$ git pr show -t 483

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/483.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318322: Update IANA Language Subtag Registry to Version 2023-10-16

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the base branch from master to pr/482 April 10, 2024 11:49
@GoeLin GoeLin changed the title Goetz backport 8318322 Backport cc8f8da293914c25cb15d38caad994bc761a3957 Apr 10, 2024
@openjdk openjdk bot changed the title Backport cc8f8da293914c25cb15d38caad994bc761a3957 8318322: Update IANA Language Subtag Registry to Version 2023-10-16 Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Apr 10, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Apr 11, 2024
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/482 to master April 11, 2024 09:22
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8318322
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Apr 11, 2024
@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Apr 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit dc53669.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@GoeLin Pushed as commit dc53669.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8318322 branch April 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant