Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 10, 2024

I backport this for parity with 21.0.4-oracle.


Progress

  • JDK-8313899 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/484/head:pull/484
$ git checkout pull/484

Update a local copy of the PR:
$ git checkout pull/484
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 484

View PR using the GUI difftool:
$ git pr show -t 484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/484.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 10, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313899: JVMCI exception Translation can fail in TranslatedException.<clinit>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ba4ad2b: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • fb10dd9: 8281658: Add a security category to the java -XshowSettings option
  • 249d896: 8328702: C2: Crash during parsing because sub type check is not folded

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6f5c903d10aa5f7ff979a79f121609c167f88eff 8313899: JVMCI exception Translation can fail in TranslatedException.<clinit> Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 10, 2024
@openjdk
Copy link

openjdk bot commented Apr 10, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 10, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

Going to push as commit d1caa3f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • c993c0c: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • fbb424f: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket
  • ba4ad2b: 8316608: Enable parallelism in vmTestbase/gc/vector tests
  • fb10dd9: 8281658: Add a security category to the java -XshowSettings option
  • 249d896: 8328702: C2: Crash during parsing because sub type check is not folded

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2024
@openjdk openjdk bot closed this Apr 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@GoeLin Pushed as commit d1caa3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant