Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8187759: Background not refreshed when painting over a transparent JFrame #487

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link

@amosshi amosshi commented Apr 11, 2024

Backport of JDK-8187759

Testing

  • Local: Not tested - the test JFrameBackgroundRefreshTest.java needs os.family == "linux", while the local is MacOS
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-04-16,19,20

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8187759 needs maintainer approval

Issue

  • JDK-8187759: Background not refreshed when painting over a transparent JFrame (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/487/head:pull/487
$ git checkout pull/487

Update a local copy of the PR:
$ git checkout pull/487
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 487

View PR using the GUI difftool:
$ git pr show -t 487

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/487.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8187759: Background not refreshed when painting over a transparent JFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • af6c585: 8327474: Review use of java.io.tmpdir in jdk tests
  • 62993e7: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • 9b04df2: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • d19b1a4: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
  • 667513a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 515783b: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes
  • 7c63791: 8319955: Improve dependencies removal during class unloading
  • 2a3c4fc: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
  • 5a94e48: 8317600: VtableStubs::stub_containing() table load not ordered wrt to stores
  • 41c8606: 8316959: Improve InlineCacheBuffer pending queue management
  • ... and 29 more: https://git.openjdk.org/jdk21u-dev/compare/249d89632c8e78b301c419678081796bf273e285...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 04d43c435d3ede519df169053dd9d724aa2312eb 8187759: Background not refreshed when painting over a transparent JFrame Apr 11, 2024
@openjdk
Copy link

openjdk bot commented Apr 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 11, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 11, 2024

Webrevs

@amosshi
Copy link
Author

amosshi commented Apr 21, 2024

/approval request "Backporting for parity with 21.0.4-oracle. Clean backport. SAP nightlies passed on 2024-04-16,19,20”

@openjdk
Copy link

openjdk bot commented Apr 21, 2024

@amosshi
8187759: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 21, 2024
@GoeLin
Copy link
Member

GoeLin commented Apr 21, 2024

I ran the test.
It reproduces the issue and passes with the fix.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 21, 2024
@amosshi
Copy link
Author

amosshi commented Apr 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit d11a065.
Since your change was applied there have been 44 commits pushed to the master branch:

  • 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • b56b6f5: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 8e438ab: 8315824: Open source several Swing Text/HTML related tests
  • 1f43e2f: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
  • a6931db: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • af6c585: 8327474: Review use of java.io.tmpdir in jdk tests
  • 62993e7: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • 9b04df2: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • d19b1a4: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
  • 667513a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • ... and 34 more: https://git.openjdk.org/jdk21u-dev/compare/249d89632c8e78b301c419678081796bf273e285...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@amosshi Pushed as commit d11a065.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8187759 branch April 23, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants