8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks

[shipilev]

Clean backport to improve C2 reliability.

Additional testing:

• New test DOES NOT fail without the patch, passes with it
• Linux x86_64 server fastdebug, all tests
• Linux x86_64 server fastdebug, 100K Fuzzer tests
• Linux x86_64 server fastdebug, Maven CTW tests

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8329163 needs maintainer approval
• JDK-8324121 needs maintainer approval

Issues

• JDK-8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks (Bug - P3 - Approved)
• JDK-8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks() (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/488/head:pull/488
$ git checkout pull/488

Update a local copy of the PR:
$ git checkout pull/488
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 488

View PR using the GUI difftool:
$ git pr show -t 488

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/488.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• c922c50: 8322962: Upcall stub might go undetected when freezing frames
• cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• 75ac9e8: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• e59f4fa: 8328194: Add a test to check default rendering engine
• 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• 262cacb: 8320061: [nmt] Multiple issues with peak accounting
• ... and 36 more: https://git.openjdk.org/jdk21u-dev/compare/7743b6ca05b8486eeb38cbbe74569401ce62fe2a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9d8d1780)
• 00: Full (9331b290)

[shipilev]

/approval request Clean backport to improve C2 reliability against overflows. Applies cleanly. All tests pass, including aggressive compiler testing. The new regression test unfortunately passes even without the fix. Usual risk for C2 changes, but the change looks simple enough, and there is no bugtail.

[openjdk]

@shipilev
8324121: The approval request has been created successfully.

[GoeLin]

Hi @shipilev
there is a folow-up bug JDK-8329163.
Maybe we should wait for the next release? Should we consider 22?

[shipilev]

Hi @shipilev there is a folow-up bug JDK-8329163. Maybe we should wait for the next release? Should we consider 22?

I think this comes under the umbrella "Let's fix current overflow/ABS-related issues", which should culminate in https://bugs.openjdk.org/browse/JDK-8328934. So I would prefer to have it sooner.

[shipilev]

/issue add 8329163

[openjdk]

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@shipilev
Adding additional issue to issue list: 8329163: C2: possible overflow in PhaseIdealLoop::extract_long_range_checks().

[shipilev]

There is a folow-up bug JDK-8329163.

Thanks for noticing, I think it was a separate issue that we could do separately, but given it is in the same code, we can couple them together. I am going to re-run some tests.

[shipilev]

Both backports are clean.

/clean

[openjdk]

@shipilev This backport pull request is now marked as clean

[GoeLin]

Hi @shipilev, I think this is a candiate for 22.

[shipilev]

Hi @shipilev, I think this is a candiate for 22.

Sure, I'll do that as well.

[shipilev]

/approval 8329163 request Clean backport, follow-up for JDK-8324121. All tests pass, including aggressive compiler testing.

[openjdk]

@shipilev
8329163: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit 3892078.
Since your change was applied there have been 49 commits pushed to the master branch:

• 3ab3f52: 8326974: ODR violation in macroAssembler_aarch64.cpp
• 5d5c678: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
• 56a9090: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
• c922c50: 8322962: Upcall stub might go undetected when freezing frames
• cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• 75ac9e8: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• ... and 39 more: https://git.openjdk.org/jdk21u-dev/compare/7743b6ca05b8486eeb38cbbe74569401ce62fe2a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 3892078.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.