-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8329545: [s390x] Fix garbage value being passed in Argument Register #492
Conversation
👋 Welcome back sjayagond! A progress list of the required criteria for merging this PR into |
@sid8606 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Fix sign extension on 4 byte load from argument stack slot to GPR, without this change the code is throwing segmentation fault while doing some operations. |
I have tested this backport patch for jdk21u-dev for release and fastdebug build. I do not see failures related to this patch. |
@TheRealMDoerr Could you please sponsor this PR? |
/sponsor |
Going to push as commit 807f21d. |
@TheRealMDoerr @sid8606 Pushed as commit 807f21d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit e0fd6c4c from the openjdk/jdk repository.
The commit being backported was authored by Sidraya Jayagond on 10 Apr 2024 and was reviewed by Amit Kumar and Martin Doerr.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/492/head:pull/492
$ git checkout pull/492
Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/492/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 492
View PR using the GUI difftool:
$ git pr show -t 492
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/492.diff
Webrev
Link to Webrev Comment