Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329545: [s390x] Fix garbage value being passed in Argument Register #492

Closed

Conversation

sid8606
Copy link
Member

@sid8606 sid8606 commented Apr 12, 2024

Hi all,

This pull request contains a backport of commit e0fd6c4c from the openjdk/jdk repository.

The commit being backported was authored by Sidraya Jayagond on 10 Apr 2024 and was reviewed by Amit Kumar and Martin Doerr.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329545 needs maintainer approval

Issue

  • JDK-8329545: [s390x] Fix garbage value being passed in Argument Register (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/492/head:pull/492
$ git checkout pull/492

Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 492

View PR using the GUI difftool:
$ git pr show -t 492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/492.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back sjayagond! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@sid8606 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329545: [s390x] Fix garbage value being passed in Argument Register

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e0fd6c4c9e30ef107ea930c8ecc449842ae4b8d4 8329545: [s390x] Fix garbage value being passed in Argument Register Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

⚠️ @sid8606 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@sid8606
Copy link
Member Author

sid8606 commented Apr 12, 2024

/approval request Fix sign extension on 4 byte load from argument stack slot to GPR, without this change the code is throwing segmentation fault while doing some operations.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@sid8606
8329545: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 12, 2024
@sid8606
Copy link
Member Author

sid8606 commented Apr 12, 2024

I have tested this backport patch for jdk21u-dev for release and fastdebug build. I do not see failures related to this patch.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@sid8606
Your change (at version 2bf165b) is now ready to be sponsored by a Committer.

@sid8606
Copy link
Member Author

sid8606 commented Apr 12, 2024

@TheRealMDoerr Could you please sponsor this PR?

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

Going to push as commit 807f21d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 12, 2024
@openjdk openjdk bot closed this Apr 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@TheRealMDoerr @sid8606 Pushed as commit 807f21d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants