Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329961: Buffer overflow in os::Linux::kernel_version #498

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Apr 12, 2024

Follow-up fix to JDK-8321075 which is in 21.0.4. Should be low risk and avoids the potential buffer-overrun.


Progress

  • JDK-8329961 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329961: Buffer overflow in os::Linux::kernel_version (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/498/head:pull/498
$ git checkout pull/498

Update a local copy of the PR:
$ git checkout pull/498
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 498

View PR using the GUI difftool:
$ git pr show -t 498

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/498.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2024

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 12, 2024

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329961: Buffer overflow in os::Linux::kernel_version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • eec41a4: 8328589: unify os::breakpoint among posix platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 279ed0ddd505fb3052b818f755b4b220ed5557e6 8329961: Buffer overflow in os::Linux::kernel_version Apr 12, 2024
@openjdk
Copy link

openjdk bot commented Apr 12, 2024

This backport pull request has now been updated with issue from the original commit.

@jerboaa jerboaa marked this pull request as ready for review April 12, 2024 16:34
@openjdk openjdk bot added approval rfr Pull request is ready for review labels Apr 12, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 12, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 15, 2024
@jerboaa
Copy link
Contributor Author

jerboaa commented Apr 15, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2024

Going to push as commit f5c0d78.
Since your change was applied there has been 1 commit pushed to the master branch:

  • eec41a4: 8328589: unify os::breakpoint among posix platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 15, 2024
@openjdk openjdk bot closed this Apr 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2024
@openjdk
Copy link

openjdk bot commented Apr 15, 2024

@jerboaa Pushed as commit f5c0d78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant