8326521: JFR: CompilerPhase event test fails on windows 32 bit

[roberttoyonaga]

This is a backport of openjdk/jdk@96530bc

On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events .

This backport prevents NeverActAsServerClassMachine from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium (see adoptium/aqa-tests#3045).

---

Progress

• Change must not contain extraneous whitespace
• JDK-8326521 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8326521: JFR: CompilerPhase event test fails on windows 32 bit (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/499/head:pull/499
$ git checkout pull/499

Update a local copy of the PR:
$ git checkout pull/499
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 499

View PR using the GUI difftool:
$ git pr show -t 499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/499.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326521: JFR: CompilerPhase event test fails on windows 32 bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

• b980e1c: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• e9e042b: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• f95de5b: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing
• 0dd4808: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
• f5c0d78: 8329961: Buffer overflow in os::Linux::kernel_version
• eec41a4: 8328589: unify os::breakpoint among posix platforms
• 807f21d: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 1825464: 8329823: RISC-V: Need to sync CPU features with related JVM flags
• db750ff: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
• dc53669: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
• ... and 106 more: https://git.openjdk.org/jdk21u-dev/compare/d1af31b6098f4c55d05aa8693ff09f6dcc1e118a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @roberttoyonaga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (bba414c2)
• 00: Full (6033bf7a)

[openjdk]

@roberttoyonaga Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[roberttoyonaga]

Pre-submit tests - linux-x86 / test - Test (tier1) fails for reasons seemingly unrelated to this PR.

Fails on test:java/util/HashMap/WhiteBoxResizeTest.java for this reason:

 Error occurred during initialization of VM
Could not reserve enough space for 2097152KB object heap

[roberttoyonaga]

/approval request for the clean backport of a JFR test fix for TestCompilerPhase. This only affects test code so should be a low risk.

[openjdk]

@roberttoyonaga
8326521: The approval request has been created successfully.

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version bba414c) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit fc7d8f8.
Since your change was applied there have been 116 commits pushed to the master branch:

• b980e1c: 8328988: [macos14] Problem list LightweightEventTest.java which fails due to macOS bug described in JDK-8322653
• e9e042b: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• f95de5b: 8320714: java/util/Locale/LocaleProvidersRun.java and java/util/ResourceBundle/modules/visibility/VisibilityTest.java timeout after passing
• 0dd4808: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi
• f5c0d78: 8329961: Buffer overflow in os::Linux::kernel_version
• eec41a4: 8328589: unify os::breakpoint among posix platforms
• 807f21d: 8329545: [s390x] Fix garbage value being passed in Argument Register
• 1825464: 8329823: RISC-V: Need to sync CPU features with related JVM flags
• db750ff: 8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI
• dc53669: 8318322: Update IANA Language Subtag Registry to Version 2023-10-16
• ... and 106 more: https://git.openjdk.org/jdk21u-dev/compare/d1af31b6098f4c55d05aa8693ff09f6dcc1e118a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @roberttoyonaga Pushed as commit fc7d8f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.