Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317317: G1: Make TestG1RemSetFlags use createTestJvm #50

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 17, 2023

I backport this to keep the 21u test suite up-to-date. This will simplify future test backports.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317317 needs maintainer approval

Issue

  • JDK-8317317: G1: Make TestG1RemSetFlags use createTestJvm (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/50/head:pull/50
$ git checkout pull/50

Update a local copy of the PR:
$ git checkout pull/50
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/50/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 50

View PR using the GUI difftool:
$ git pr show -t 50

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/50.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5bd10521eb5e51e76b20e955addd45f76abba6f7 8317317: G1: Make TestG1RemSetFlags use createTestJvm Dec 17, 2023
@openjdk
Copy link

openjdk bot commented Dec 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 17, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 17, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 20, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317317: G1: Make TestG1RemSetFlags use createTestJvm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 3e4adb6: 8320168: handle setsocktopt return values
  • c725f4b: 8321374: Add a configure option to explicitly set CompanyName property in VersionInfo resource for Windows exe/dll
  • 2433635: 8314220: Configurable InlineCacheBuffer size
  • 03acee8: 8314578: Non-verifiable code is emitted when two guards declare pattern variables in colon-switch
  • af6df77: 8305971: NPE in JavacProcessingEnvironment for missing enum constructor body
  • f55a91a: 8319897: Move StackWatermark handling out of LockStack::contains
  • b8a0d9f: 8316229: Enhance class initialization logging
  • 5d32860: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 0c92460: 8309302: java/net/Socket/Timeouts.java fails with AssertionError on test temporal post condition
  • 6644066: 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory
  • ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/fccb0a150a0ac37c52c52a8011f7bca1409bf612...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit eb6fedc.
Since your change was applied there have been 42 commits pushed to the master branch:

  • 4f6a2e6: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 5f7b7c5: 8317347: Parallel: Make TestInitialTenuringThreshold use createTestJvm
  • 4846aa2: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • afa729c: 8316446: 4 sun/management/jdp tests ignore VM flags
  • f4e7c0c: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829
  • e514578: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags
  • 1545967: 8313638: Add test for dump of resolved references
  • ebd5179: 8314831: NMT tests ignore vm flags
  • 320cf85: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 20dd66b: 8314333: Update com/sun/jdi/ProcessAttachTest.java to use ProcessTools.createTestJvm(..)
  • ... and 32 more: https://git.openjdk.org/jdk21u-dev/compare/fccb0a150a0ac37c52c52a8011f7bca1409bf612...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@GoeLin Pushed as commit eb6fedc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant