8327971: Multiple ASAN errors reported for metaspace

[SoniaZaldana]

Hi all,

This PR contains a backport of 9e566d76d1d8acca27d8f69fffcbeb0b49b060ba.

Patch is not clean because of differences with #include statements.

Testing:

• Verified fastdebug build failed with --enable-asan prior to backport
• Verified fastdebug build succeeded with --enable-asan after backport
• Verified NMT gtests passed after backport

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8327971 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8327988 needs maintainer approval

Issues

• JDK-8327971: Multiple ASAN errors reported for metaspace (Bug - P4 - Approved)
• JDK-8327988: When running ASAN, disable dangerous NMT test (Bug - P4 - Approved)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/504/head:pull/504
$ git checkout pull/504

Update a local copy of the PR:
$ git checkout pull/504
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 504

View PR using the GUI difftool:
$ git pr show -t 504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/504.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327971: Multiple ASAN errors reported for metaspace
8327988: When running ASAN, disable dangerous NMT test

Reviewed-by: stuefe, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
• febbf35: 8316242: Opensource SwingGraphics manual test
• 1861655: 8316154: Opensource JTextArea manual tests
• a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
• bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
• ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
• 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
• b56b6f5: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• 8e438ab: 8315824: Open source several Swing Text/HTML related tests
• ... and 29 more: https://git.openjdk.org/jdk21u-dev/compare/f5c0d7824fac3ceb45ad405ee242b6f5909dd25e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[mlbridge]

Webrevs

• 00: Full (faa67749)

[tstuefe]

Looks good.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version faa6774) is now ready to be sponsored by a Committer.

[shipilev]

Looks fine to me as well.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 324cef1.
Since your change was applied there have been 39 commits pushed to the master branch:

• ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
• febbf35: 8316242: Opensource SwingGraphics manual test
• 1861655: 8316154: Opensource JTextArea manual tests
• a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
• bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
• ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
• 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
• b56b6f5: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
• 8e438ab: 8315824: Open source several Swing Text/HTML related tests
• ... and 29 more: https://git.openjdk.org/jdk21u-dev/compare/f5c0d7824fac3ceb45ad405ee242b6f5909dd25e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @SoniaZaldana Pushed as commit 324cef1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.