8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

[zifeihan]

The same issue reproduces for 17u and 21u too if we apply fix for JDK- 8316186 and JDK-8316893 which are both code cleanup/enhancement. So I suggest we backport JDK-8326936 and its followup fix JDK-8330242 to be safe.

Testing

• The affected jtreg test cases all pass with jdk release built with latest gcc-13 development branch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316186 needs maintainer approval
• JDK-8326936 needs maintainer approval
• JDK-8330242 needs maintainer approval

Issues

• JDK-8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations (Bug - P4 - Approved)
• JDK-8316186: RISC-V: Remove PlatformCmpxchg<4> (Enhancement - P5 - Approved)
• JDK-8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp (Enhancement - P4 - Approved)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/507/head:pull/507
$ git checkout pull/507

Update a local copy of the PR:
$ git checkout pull/507
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 507

View PR using the GUI difftool:
$ git pr show -t 507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/507.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations
8316186: RISC-V: Remove PlatformCmpxchg<4>
8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[zifeihan]

/issue add 8316186, 8330242

[openjdk]

@zifeihan
Adding additional issue to issue list: 8316186: RISC-V: Remove PlatformCmpxchg<4>.

Adding additional issue to issue list: 8330242: RISC-V: Simplify and remove CORRECT_COMPILER_ATOMIC_SUPPORT in atomic_linux_riscv.hpp.

[mlbridge]

Webrevs

• 00: Full (433b6c7b)

[RealFYang]

LGTM. Thanks.

[openjdk]

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[zifeihan]

@RealFYang : Thanks for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version 433b6c7) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[zifeihan]

/integrate

[shipilev]

Bots seem to be stuck, huh? I wrote to ops@...

[openjdk]

Going to push as commit f0f2e70.

[openjdk]

@RealFYang @zifeihan Pushed as commit f0f2e70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@zifeihan The command integrate can only be used in open pull requests.