8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

[shipilev]

Fixes a corner case bug in Epsilon.

Additional testing:

• MacOS AArch64 server fastdebug, gc/epsilon

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8328166 needs maintainer approval

Issue

• JDK-8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/515/head:pull/515
$ git checkout pull/515

Update a local copy of the PR:
$ git checkout pull/515
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 515

View PR using the GUI difftool:
$ git pr show -t 515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/515.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 7c63791: 8319955: Improve dependencies removal during class unloading
• 2a3c4fc: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
• 5a94e48: 8317600: VtableStubs::stub_containing() table load not ordered wrt to stores
• 41c8606: 8316959: Improve InlineCacheBuffer pending queue management
• f341621: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
• e63addb: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
• 686399a: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
• 6c5500b: 8318986: Improve GenericWaitBarrier performance
• f0f2e70: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Fixes a corner case bug/inefficiency in Epsilon. Applies cleanly. Testing passes. Risk is low, the patch is simple and limited to Epsilon.

[openjdk]

@shipilev
8328166: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (629fe297)

[shipilev]

/integrate

[openjdk]

Going to push as commit 515783b.
Since your change was applied there have been 9 commits pushed to the master branch:

• 7c63791: 8319955: Improve dependencies removal during class unloading
• 2a3c4fc: 8318109: Writing JFR records while a CHT has taken its lock asserts in rank checking
• 5a94e48: 8317600: VtableStubs::stub_containing() table load not ordered wrt to stores
• 41c8606: 8316959: Improve InlineCacheBuffer pending queue management
• f341621: 8323685: PrintSystemDictionaryAtExit has mutex rank assert
• e63addb: 8315503: G1: Code root scan causes long GC pauses due to imbalanced iteration
• 686399a: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
• 6c5500b: 8318986: Improve GenericWaitBarrier performance
• f0f2e70: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 515783b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.