Skip to content

8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass#517

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-21d361e9
Closed

8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass#517
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-21d361e9

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 22, 2024

I backport this as prereq of JDK-8317809.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320525 needs maintainer approval

Issue

  • JDK-8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/517/head:pull/517
$ git checkout pull/517

Update a local copy of the PR:
$ git checkout pull/517
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 517

View PR using the GUI difftool:
$ git pr show -t 517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/517.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 8e438ab: 8315824: Open source several Swing Text/HTML related tests
  • 1f43e2f: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
  • a6931db: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • af6c585: 8327474: Review use of java.io.tmpdir in jdk tests
  • 62993e7: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • 9b04df2: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • d19b1a4: 8327486: java/util/Properties/PropertiesStoreTest.java fails "Text 'xxx' could not be parsed at index 20" after 8174269
  • 667513a: 8325028: (ch) Pipe channels should lazily set socket to non-blocking mode on first use by virtual thread
  • 515783b: 8328166: Epsilon: 'EpsilonHeap::allocate_work' misuses the parameter 'size' as size in bytes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 21d361e944a599e82e5ed93aa81ad485b4601843 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 23, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Apr 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit bb046b7.
Since your change was applied there have been 13 commits pushed to the master branch:

  • ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
  • 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
  • b56b6f5: 8327136: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java fails on libgraal
  • 8e438ab: 8315824: Open source several Swing Text/HTML related tests
  • 1f43e2f: 8326006: Allow TEST_VM_FLAGLESS to set flagless mode
  • a6931db: 8315071: Modify TrayIconScalingTest.java, PrintLatinCJKTest.java to use new PassFailJFrame's builder pattern usage
  • af6c585: 8327474: Review use of java.io.tmpdir in jdk tests
  • 62993e7: 8328555: hidpi problems for test java/awt/Dialog/DialogAnotherThread/JaWSTest.java
  • 9b04df2: 8327180: Failed: java/io/ObjectStreamClass/ObjectStreamClassCaching.java#G1
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/7c6379146e3b5c5625ff25f1585d3d14d778ed70...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@GoeLin Pushed as commit bb046b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant