Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size #518

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 22, 2024

Fixes Epsilon performance problem, corner-case with clear test.

Additional testing:

  • MacOS AArch64 server fastdebug, new regression test fails without the patch, passes with it
  • MacOS AArch64 server fastdebug, gc/epsilon

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328168 needs maintainer approval

Issue

  • JDK-8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/518/head:pull/518
$ git checkout pull/518

Update a local copy of the PR:
$ git checkout pull/518
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 518

View PR using the GUI difftool:
$ git pr show -t 518

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/518.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
  • d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
  • d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
  • e59f4fa: 8328194: Add a test to check default rendering engine
  • 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • 262cacb: 8320061: [nmt] Multiple issues with peak accounting
  • 1d01cd7: 8315889: Open source several Swing HTMLDocument related tests
  • 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 68d0925: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7baec6622254fc21e315b974a213605a7605daac 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2024
@shipilev
Copy link
Member Author

/approval request Fixes Epsilon performance problem, corner-case with clear test. Applies cleanly. New regression test fails without the fix, passes with it. Other Epsilon tests pass as well. There is no bugtail after a month in mainline.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@shipilev
8328168: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 22, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 29, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

Going to push as commit 75ac9e8.
Since your change was applied there have been 33 commits pushed to the master branch:

  • a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
  • d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
  • d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
  • e59f4fa: 8328194: Add a test to check default rendering engine
  • 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
  • 262cacb: 8320061: [nmt] Multiple issues with peak accounting
  • 1d01cd7: 8315889: Open source several Swing HTMLDocument related tests
  • 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 68d0925: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2024
@openjdk openjdk bot closed this Apr 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@shipilev Pushed as commit 75ac9e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant