8325095: C2: bailout message broken: ResourceArea allocated string used after free

[shipilev]

Fixes the diagnostic regression in JDK 21. Does not apply cleanly, because JDK 21 does not have JDK-8318444. I tried to backport it first, but it has some bugtail, which needs more time in mainline. The conflicts resolutions were simple.

Additional testing:

• Linux x86_64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325095 needs maintainer approval

Issue

• JDK-8325095: C2: bailout message broken: ResourceArea allocated string used after free (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/522/head:pull/522
$ git checkout pull/522

Update a local copy of the PR:
$ git checkout pull/522
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 522

View PR using the GUI difftool:
$ git pr show -t 522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/522.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325095: C2: bailout message broken: ResourceArea allocated string used after free

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• e59f4fa: 8328194: Add a test to check default rendering engine
• 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• 262cacb: 8320061: [nmt] Multiple issues with peak accounting
• 1d01cd7: 8315889: Open source several Swing HTMLDocument related tests
• 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• 68d0925: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
• ... and 23 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9009d999)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Fixes the diagnostic regression in JDK 21. Does not apply cleanly, but easy to resolve. Fixes a regression that touches uninitialized memory in product bits, low-medium risk.

[openjdk]

@shipilev
8325095: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit cbd30c9.
Since your change was applied there have been 34 commits pushed to the master branch:

• 75ac9e8: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• e59f4fa: 8328194: Add a test to check default rendering engine
• 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653
• 262cacb: 8320061: [nmt] Multiple issues with peak accounting
• 1d01cd7: 8315889: Open source several Swing HTMLDocument related tests
• 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
• ... and 24 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit cbd30c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.