8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest

[shipilev]

Cleans up internal verification test, moves it to proper gtest, allows more clean future backports.

Additional testing:

• MacOS AArch64 server fastdebug, new test passes

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8310355 needs maintainer approval

Issue

• JDK-8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/528/head:pull/528
$ git checkout pull/528

Update a local copy of the PR:
$ git checkout pull/528
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 528

View PR using the GUI difftool:
$ git pr show -t 528

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/528.diff

Webrev

Link to Webrev Comment

[shipilev]

/approval request Cleans up internal verification test, moves it to proper gtest, allows more clean future backports. Risk is low, debug/test-only change.

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 031acf1: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
• 324cef1: 8327971: Multiple ASAN errors reported for metaspace
• ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
• febbf35: 8316242: Opensource SwingGraphics manual test
• 1861655: 8316154: Opensource JTextArea manual tests
• a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
• bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
• ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
• 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
• ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@shipilev
8310355: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (00330ac9)

[shipilev]

/integrate

[openjdk]

Going to push as commit 955fcc1.
Since your change was applied there have been 19 commits pushed to the master branch:

• 031acf1: 8327096: (fc) java/nio/channels/FileChannel/Size.java fails on partition incapable of creating large files
• 324cef1: 8327971: Multiple ASAN errors reported for metaspace
• ac402fb: 8293850: need a largest_committed metric for each category of NMT's output
• febbf35: 8316242: Opensource SwingGraphics manual test
• 1861655: 8316154: Opensource JTextArea manual tests
• a36d3de: 8328957: Update PKCS11Test.java to not use hardcoded path
• bb046b7: 8320525: G1: G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes accesses partially unloaded klass
• ffdde9c: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
• d11a065: 8187759: Background not refreshed when painting over a transparent JFrame
• 5880551: 8318854: [macos14] Running any AWT app prints Secure coding warning
• ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/515783b86c5efae1f5385b4bc869869af58cb5bc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 955fcc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.