Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315889: Open source several Swing HTMLDocument related tests #529

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Apr 24, 2024

This is a backport of 8f46abc9 from openjdk/jdk. It introduces four newly open-sourced Swing tests and makes no other changes.

The tests all pass in jdk21u-dev.


Progress

  • JDK-8315889 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315889: Open source several Swing HTMLDocument related tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/529/head:pull/529
$ git checkout pull/529

Update a local copy of the PR:
$ git checkout pull/529
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 529

View PR using the GUI difftool:
$ git pr show -t 529

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/529.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315889: Open source several Swing HTMLDocument  related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 68d0925: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • 2626d73: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • 9c0e18c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 41237fc: 8320707: Virtual thread test updates
  • 955fcc1: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8f46abc938ffe338e25d5fdbdcfa0aaa12edfa58 8315889: Open source several Swing HTMLDocument related tests Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

This backport pull request has now been updated with issue from the original commit.

@jmtd
Copy link
Author

jmtd commented Apr 24, 2024

/approval request 4 newly open sourced swing tests. all pass in jdk21u-dev. no other changes. TIA!

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@jmtd
8315889: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Apr 24, 2024
@jmtd jmtd marked this pull request as ready for review April 25, 2024 08:49
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Apr 26, 2024

Please make sure all the broken GHA tests are unrelated!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 26, 2024
@jmtd
Copy link
Author

jmtd commented Apr 26, 2024

Please make sure all the broken GHA tests are unrelated!

Confirmed: they are all failing in the configure step due to some kind of Ubuntu repository signing problem. I don't know if that is transient or if we have a tracker for it yet

E: Failed to fetch https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease  Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?)
E: The repository 'https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease' is no longer signed.

since unrelated,
/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

Going to push as commit 1d01cd7.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 2331bc7: 8329013: StackOverflowError when starting Apache Tomcat with signed jar
  • 68d0925: 8324933: ConcurrentHashTable::statistics_calculate synchronization is expensive
  • 2626d73: 8327989: java/net/httpclient/ManyRequest.java should not use "localhost" in URIs
  • 9c0e18c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 41237fc: 8320707: Virtual thread test updates
  • 955fcc1: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2024
@openjdk openjdk bot closed this Apr 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@jmtd Pushed as commit 1d01cd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants