-
Notifications
You must be signed in to change notification settings - Fork 129
8315889: Open source several Swing HTMLDocument related tests #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
@jmtd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
/approval request 4 newly open sourced swing tests. all pass in jdk21u-dev. no other changes. TIA! |
|
Please make sure all the broken GHA tests are unrelated! |
Confirmed: they are all failing in the configure step due to some kind of Ubuntu repository signing problem. I don't know if that is transient or if we have a tracker for it yet
since unrelated, |
Going to push as commit 1d01cd7.
Your commit was automatically rebased without conflicts. |
This is a backport of 8f46abc9 from openjdk/jdk. It introduces four newly open-sourced Swing tests and makes no other changes.
The tests all pass in jdk21u-dev.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/529/head:pull/529
$ git checkout pull/529
Update a local copy of the PR:
$ git checkout pull/529
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/529/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 529
View PR using the GUI difftool:
$ git pr show -t 529
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/529.diff
Webrev
Link to Webrev Comment