8326974: ODR violation in macroAssembler_aarch64.cpp

[lewurm]

This pull request contains a backport of commit b972997a from the openjdk/jdk repository.

The commit being backported was authored by Andrew Haley on 1 Mar 2024 and was reviewed by Andrew Dinn, Aleksey Shipilev and Guoxiong Li.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8326974 needs maintainer approval

Issue

• JDK-8326974: ODR violation in macroAssembler_aarch64.cpp (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/534/head:pull/534
$ git checkout pull/534

Update a local copy of the PR:
$ git checkout pull/534
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 534

View PR using the GUI difftool:
$ git pr show -t 534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/534.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lewurm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326974: ODR violation in macroAssembler_aarch64.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 75ac9e8: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• e59f4fa: 8328194: Add a test to check default rendering engine
• 6f07ee4: 8324733: [macos14] Problem list tests which fail due to macOS bug described in JDK-8322653

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lewurm This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (ba298a40)

[lewurm]

/approval request "Fixes the build with certain toolchains. Clean backport, low risk."

[openjdk]

@lewurm
8326974: The approval request has been created successfully.

[lewurm]

/integrate

[openjdk]

@lewurm
Your change (at version ba298a4) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 3ab3f52.
Since your change was applied there have been 11 commits pushed to the master branch:

• 5d5c678: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
• 56a9090: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
• c922c50: 8322962: Upcall stub might go undetected when freezing frames
• cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free
• 75ac9e8: 8328168: Epsilon: Premature OOM when allocating object larger than uncommitted heap size
• a0e8de8: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• e7ebae5: 8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder
• d8bc9e4: 8331113: createJMHBundle.sh support configurable maven repo mirror
• d1b97d4: 8309142: Refactor test/langtools/tools/javac/versions/Versions.java
• e59f4fa: 8328194: Add a test to check default rendering engine
• ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/262cacb2385af4e0e2ee3a4e1f763b68e3101f28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @lewurm Pushed as commit 3ab3f52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[lewurm]

Thank you for sponsoring Aleksey!