8330011: [s390x] update block-comments to make code consistent

[offamitkumar]

Hi all,

This pull request contains a backport of commit 01bda278 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 17 Apr 2024 and was reviewed by Lutz Schmidt.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8330011 needs maintainer approval

Issue

• JDK-8330011: [s390x] update block-comments to make code consistent (Bug - P4 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/539/head:pull/539
$ git checkout pull/539

Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 539

View PR using the GUI difftool:
$ git pr show -t 539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/539.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330011: [s390x] update block-comments to make code consistent

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 3bb8eee: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
• a4d8d06: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
• 87d5da4: 8328822: C2: "negative trip count?" assert failure in profile predicate code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (596a9d0d)
• 00: Full (5b91fd15)

[offamitkumar]

@RealLucy would you take a quick look here as well. In this I had to modify the comments manually there were some other conflicts as well other than copyright header.

But still it only updates the comments , and minor c++ code alignment fix.

[RealLucy]

LGTM.

[openjdk]

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[RealLucy]

Done. From: Amit Kumar ***@***.***> Date: Tuesday, 30. April 2024 at 09:08 To: openjdk/jdk21u-dev ***@***.***> Cc: Schmidt, Lutz ***@***.***>, Mention ***@***.***> Subject: Re: [openjdk/jdk21u-dev] 8330011: [s390x] update block-comments to make code consistent (PR #539) @RealLucy<https://github.com/RealLucy> would you take a quick look here as well. In this I had to modify the comments manually there were some other conflicts as well other than copyright header. But still it only updates the comments , and minor c++ code alignment fix. — Reply to this email directly, view it on GitHub<#539 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ6PCMINMLWDDO5KCC7CJR3Y747NFAVCNFSM6AAAAABG32FIGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUGUZTGNJYHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[offamitkumar]

/approval request Had to backport this change as Panama was ported in JDK-21 so comment needs to updated in JDK-21 repo as well.

[openjdk]

@offamitkumar
8330011: The approval request has been created successfully.

[GoeLin]

Hi Amit, here also tests are missing. Also, please elaborate on the Risk in your fix-request comments.

[openjdk]

@offamitkumar Usage: /backport [disable] <repository> [<branch>] or /backport [disable] [<repository>]:<branch>

[offamitkumar]

/approval request Had to backport this change as Panama was ported in JDK-21 so comment needs to updated in JDK-21 repo as well. As only comments are being updated. So risk here is low.

[openjdk]

@offamitkumar
8330011: The approval request has been updated successfully.

[offamitkumar]

/integrate

[openjdk]

@offamitkumar
Your change (at version 596a9d0) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 3ff5359.
Since your change was applied there have been 8 commits pushed to the master branch:

• abbad92: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
• 3770c28: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• 021372c: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0
• d459ae9: 8329850: [AIX] Allow loading of different members of same shared library archive
• 835d016: 8330094: RISC-V: Save and restore FRM in the call stub
• 3bb8eee: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
• a4d8d06: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
• 87d5da4: 8328822: C2: "negative trip count?" assert failure in profile predicate code

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @offamitkumar Pushed as commit 3ff5359.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.