-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312014: [s390x] TestSigInfoInHsErrFile.java Failure #541
8312014: [s390x] TestSigInfoInHsErrFile.java Failure #541
Conversation
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request This test is also reproducible in JDK-21 as well. So need to backport the fix. |
@offamitkumar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
No formal Review needed, though. The automatic backport was detected to be clean (no manual intervention required).
Thanks @RealLucy for review :-) /integrate |
@offamitkumar |
/sponsor |
Going to push as commit 56a9090.
Your commit was automatically rebased without conflicts. |
@RealLucy @offamitkumar Pushed as commit 56a9090. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 6f662130 from the openjdk/jdk repository.
The commit being backported was authored by Sidraya on 19 Jul 2023 and was reviewed by Thomas Stuefe, Amit Kumar and Tyler Steele.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/541/head:pull/541
$ git checkout pull/541
Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/541/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 541
View PR using the GUI difftool:
$ git pr show -t 541
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/541.diff
Webrev
Link to Webrev Comment