Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312014: [s390x] TestSigInfoInHsErrFile.java Failure #541

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Apr 29, 2024

Hi all,

This pull request contains a backport of commit 6f662130 from the openjdk/jdk repository.

The commit being backported was authored by Sidraya on 19 Jul 2023 and was reviewed by Thomas Stuefe, Amit Kumar and Tyler Steele.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8312014 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8312014: [s390x] TestSigInfoInHsErrFile.java Failure (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/541/head:pull/541
$ git checkout pull/541

Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 541

View PR using the GUI difftool:
$ git pr show -t 541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/541.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312014: [s390x] TestSigInfoInHsErrFile.java Failure

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c922c50: 8322962: Upcall stub might go undetected when freezing frames
  • cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6f6621303ad54a7dfd880c9472a387706a4466ff 8312014: [s390x] TestSigInfoInHsErrFile.java Failure Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 29, 2024
@offamitkumar
Copy link
Member Author

/approval request This test is also reproducible in JDK-21 as well. So need to backport the fix.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@offamitkumar
8312014: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Apr 29, 2024

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
No formal Review needed, though. The automatic backport was detected to be clean (no manual intervention required).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 29, 2024
@offamitkumar
Copy link
Member Author

Thanks @RealLucy for review :-)

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@offamitkumar
Your change (at version 3d20f72) is now ready to be sponsored by a Committer.

@RealLucy
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

Going to push as commit 56a9090.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c922c50: 8322962: Upcall stub might go undetected when freezing frames
  • cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 30, 2024
@openjdk openjdk bot closed this Apr 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 30, 2024
@openjdk
Copy link

openjdk bot commented Apr 30, 2024

@RealLucy @offamitkumar Pushed as commit 56a9090.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants