Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329850: [AIX] Allow loading of different members of same shared library archive #542

Closed

Conversation

JoKern65
Copy link

@JoKern65 JoKern65 commented Apr 29, 2024

Hi all,

This pull request contains a backport of commit cfd19f01 from the openjdk/jdk repository.

The commit being backported was authored by Joachim Kern on 26 Apr 2024 and was reviewed by Martin Doerr, Matthias Baesken and Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329850 needs maintainer approval

Issue

  • JDK-8329850: [AIX] Allow loading of different members of same shared library archive (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/542/head:pull/542
$ git checkout pull/542

Update a local copy of the PR:
$ git checkout pull/542
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 542

View PR using the GUI difftool:
$ git pr show -t 542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/542.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2024

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@JoKern65 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329850: [AIX] Allow loading of different members of same shared library archive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 3bb8eee: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
  • a4d8d06: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • 87d5da4: 8328822: C2: "negative trip count?" assert failure in profile predicate code
  • 3892078: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
  • 3ab3f52: 8326974: ODR violation in macroAssembler_aarch64.cpp
  • 5d5c678: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
  • 56a9090: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
  • c922c50: 8322962: Upcall stub might go undetected when freezing frames
  • cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport cfd19f017681a7aded67937c5132263bbcc7be6f 8329850: [AIX] Allow loading of different members of same shared library archive Apr 29, 2024
@openjdk
Copy link

openjdk bot commented Apr 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

⚠️ @JoKern65 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 29, 2024
@JoKern65
Copy link
Author

/approval JDK-8329850 request Backport of Bug fix for AIX. No risk, clean backport.

@openjdk
Copy link

openjdk bot commented Apr 29, 2024

@JoKern65
JDK-8329850: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 29, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 3, 2024
@JoKern65
Copy link
Author

JoKern65 commented May 3, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

@JoKern65
Your change (at version 65008e8) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented May 6, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 6, 2024

Going to push as commit d459ae9.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 835d016: 8330094: RISC-V: Save and restore FRM in the call stub
  • 3bb8eee: 8317809: Insertion of free code blobs into code cache can be very slow during class unloading
  • a4d8d06: 8328744: Parallel: Parallel GC throws OOM before heap is fully expanded
  • 87d5da4: 8328822: C2: "negative trip count?" assert failure in profile predicate code
  • 3892078: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks
  • 3ab3f52: 8326974: ODR violation in macroAssembler_aarch64.cpp
  • 5d5c678: 8319713: Parallel: Remove PSAdaptiveSizePolicy::should_full_GC
  • 56a9090: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
  • c922c50: 8322962: Upcall stub might go undetected when freezing frames
  • cbd30c9: 8325095: C2: bailout message broken: ResourceArea allocated string used after free

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2024
@openjdk openjdk bot closed this May 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

@GoeLin @JoKern65 Pushed as commit d459ae9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants