-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330094: RISC-V: Save and restore FRM in the call stub #545
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
/approve yes |
@jerboaa |
@RealFYang @jerboaa : Thanks for the review. |
/sponsor |
Going to push as commit 835d016.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit 835d016. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, The same issue also exists in JDK21u. So I would like to backport JDK-8330094 to jdk21u-dev. With this change, we save and restore the default floating-point control state when we enter and leave Java code, ensuring that we are still Java compatible if we're called via the JNI invocation interface with a weird FP control state. RISC-V specific change, risk is low.
The backport is not clean because jdk21u-dev has no JDK-8321021
Testing
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/545/head:pull/545
$ git checkout pull/545
Update a local copy of the PR:
$ git checkout pull/545
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/545/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 545
View PR using the GUI difftool:
$ git pr show -t 545
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/545.diff
Webrev
Link to Webrev Comment