8325621: Improve jspawnhelper version checks

[chadrako]

Backport of JDK-8325621

Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325621 needs maintainer approval

Issue

• JDK-8325621: Improve jspawnhelper version checks (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/547/head:pull/547
$ git checkout pull/547

Update a local copy of the PR:
$ git checkout pull/547
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 547

View PR using the GUI difftool:
$ git pr show -t 547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/547.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chadrako This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325621: Improve jspawnhelper version checks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

• e3a9226: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
• c12dfc3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• ddecbe5: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 93d091a: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account
• 41fda4a: 8319376: ParallelGC: Forwarded objects found during heap inspection
• ec6b326: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared
• 92b43c5: 8317007: Add bulk removal of dead nmethods during class unloading
• ed2f5a8: 8310228: Improve error reporting for uncaught native exceptions on Windows
• 7a400f2: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
• 16ba673: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3
• ... and 32 more: https://git.openjdk.org/jdk21u-dev/compare/031acf1c9f4e9f89ab7537eed0212b34b68fae0d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @chadrako This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[chadrako]

/approval 8325621 request Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper

[openjdk]

@chadrako
8325621: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (bc35952c)

[chadrako]

/approval 8325621 request Clean backport to update jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. GHA tests pass including the updated test. This has been backported to JDK22. Risk is low: touches the production code paths but only passes an additional argument to jspawnhelper.

[openjdk]

@chadrako
8325621: The approval request has been updated successfully.

[chadrako]

/integrate

[openjdk]

@chadrako
Your change (at version bc35952) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit fa874b3.
Since your change was applied there have been 42 commits pushed to the master branch:

• e3a9226: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
• c12dfc3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• ddecbe5: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 93d091a: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account
• 41fda4a: 8319376: ParallelGC: Forwarded objects found during heap inspection
• ec6b326: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared
• 92b43c5: 8317007: Add bulk removal of dead nmethods during class unloading
• ed2f5a8: 8310228: Improve error reporting for uncaught native exceptions on Windows
• 7a400f2: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
• 16ba673: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3
• ... and 32 more: https://git.openjdk.org/jdk21u-dev/compare/031acf1c9f4e9f89ab7537eed0212b34b68fae0d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @chadrako Pushed as commit fa874b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.