Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317007: Add bulk removal of dead nmethods during class unloading #548

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 2, 2024

I backport this for parity with 21.0.4-oracle.

Clean patch on top of 8317809.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317007 needs maintainer approval

Issue

  • JDK-8317007: Add bulk removal of dead nmethods during class unloading (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/548/head:pull/548
$ git checkout pull/548

Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 548

View PR using the GUI difftool:
$ git pr show -t 548

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/548.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/505 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317007: Add bulk removal of dead nmethods during class unloading

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d459ae9: 8329850: [AIX] Allow loading of different members of same shared library archive
  • 835d016: 8330094: RISC-V: Save and restore FRM in the call stub

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f55381950266088cc0284754b16663675867ac87 8317007: Add bulk removal of dead nmethods during class unloading May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels May 2, 2024
@mlbridge
Copy link

mlbridge bot commented May 2, 2024

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/505 to master May 3, 2024 06:24
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8317007
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented May 3, 2024

I force-pushed because I prepared a new clean patch on my local repo. Instead, I would have had to resolve a hand full of files which is error-prone.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented May 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2024

Going to push as commit 92b43c5.
Since your change was applied there have been 11 commits pushed to the master branch:

  • ed2f5a8: 8310228: Improve error reporting for uncaught native exceptions on Windows
  • 7a400f2: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition
  • 16ba673: 8331639: [21u]: Bump GHA bootstrap JDK to 21.0.3
  • 2b858f5: 8328938: C2 SuperWord: disable vectorization for large stride and scale
  • 9159882: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking
  • 3ff5359: 8330011: [s390x] update block-comments to make code consistent
  • abbad92: 8326201: [S390] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • 3770c28: 8331331: :tier1 target explanation in doc/testing.md is incorrect
  • 021372c: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0
  • d459ae9: 8329850: [AIX] Allow loading of different members of same shared library archive
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/3bb8eeed4817d490a1089aa567434af3f303c4f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2024
@openjdk openjdk bot closed this May 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@GoeLin Pushed as commit 92b43c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8317007 branch May 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant