Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329663: hs_err file event log entry for thread adding/removing should print current thread #553

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 6, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8329663 needs maintainer approval

Issue

  • JDK-8329663: hs_err file event log entry for thread adding/removing should print current thread (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/553/head:pull/553
$ git checkout pull/553

Update a local copy of the PR:
$ git checkout pull/553
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 553

View PR using the GUI difftool:
$ git pr show -t 553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/553.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329663: hs_err file event log entry for thread adding/removing should print current thread

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 5b5d778: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 035e314: 8324243: Compilation failures in java.desktop module with gcc 14
  • fbb0f4c: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • bddd6a7: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • 153de5a: 8320370: NMT: Change MallocMemorySnapshot to simplify code.
  • fa874b3: 8325621: Improve jspawnhelper version checks
  • e3a9226: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • c12dfc3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
  • ddecbe5: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • 93d091a: 8314573: G1: Heap resizing at Remark does not take existing eden regions into account
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/7a400f2a5945139efaa9323231df83cc592c68fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3ebf8c9359da2f45e4cefb7be2276d33c30979aa 8329663: hs_err file event log entry for thread adding/removing should print current thread May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels May 6, 2024
@mlbridge
Copy link

mlbridge bot commented May 6, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 15, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit 87fe0d2.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 9b8f988: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 30f0779: 8331167: UBSan enabled build fails in adlc on macOS
  • fdb82f4: 8328997: Remove unnecessary template parameter lists in GrowableArray
  • 87318f8: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • 59ca009: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • 2429a90: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • 5b5d778: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 035e314: 8324243: Compilation failures in java.desktop module with gcc 14
  • fbb0f4c: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • bddd6a7: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"
  • ... and 10 more: https://git.openjdk.org/jdk21u-dev/compare/7a400f2a5945139efaa9323231df83cc592c68fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@MBaesken Pushed as commit 87fe0d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant