Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328997: Remove unnecessary template parameter lists in GrowableArray #564

Closed
wants to merge 1 commit into from

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented May 13, 2024

It is needed to build OpenJDK-21 on Fedora 40 x86_64 (gcc-14.1.1-1.fc40.x86_64).
It needs all of JDK-8328997 (this backport), JDK-8331352 (backport) and JDK-8324243 (backport).
Git cherry-pick was not clean but it was a non-issue.


Progress

  • JDK-8328997 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328997: Remove unnecessary template parameter lists in GrowableArray (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/564/head:pull/564
$ git checkout pull/564

Update a local copy of the PR:
$ git checkout pull/564
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 564

View PR using the GUI difftool:
$ git pr show -t 564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/564.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328997: Remove unnecessary template parameter lists in GrowableArray

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 59ca009: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • 2429a90: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • 5b5d778: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 035e314: 8324243: Compilation failures in java.desktop module with gcc 14
  • fbb0f4c: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • bddd6a7: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @jankratochvil could not find any commit with hash d792c115b812eae2500a09b126b18321d9474a10. Please update the title with the hash for an existing commit.

@jankratochvil jankratochvil changed the title Backport d792c115b812eae2500a09b126b18321d9474a10 Backport 3d2283800acee58dbf046c8b401a5a144ab65ed1 May 13, 2024
@openjdk openjdk bot changed the title Backport 3d2283800acee58dbf046c8b401a5a144ab65ed1 8328997: Remove unnecessary template parameter lists in GrowableArray May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 13, 2024

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@openjdk openjdk bot added the approval label May 14, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 15, 2024
@jankratochvil
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@jankratochvil
Your change (at version 9548e36) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 15, 2024

Going to push as commit fdb82f4.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 87318f8: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • 59ca009: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
  • 2429a90: 8325255: jdk.internal.util.ReferencedKeySet::add using wrong test
  • 5b5d778: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 035e314: 8324243: Compilation failures in java.desktop module with gcc 14
  • fbb0f4c: 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)
  • bddd6a7: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 15, 2024
@openjdk openjdk bot closed this May 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 15, 2024
@openjdk
Copy link

openjdk bot commented May 15, 2024

@TheRealMDoerr @jankratochvil Pushed as commit fdb82f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants