Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329862: libjli GetApplicationHome cleanups and enhance jli tracing #570

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented May 14, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8329862 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8329862: libjli GetApplicationHome cleanups and enhance jli tracing (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/570/head:pull/570
$ git checkout pull/570

Update a local copy of the PR:
$ git checkout pull/570
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 570

View PR using the GUI difftool:
$ git pr show -t 570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/570.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329862: libjli GetApplicationHome cleanups and enhance jli tracing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 4b1d95c: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d986096: 8330464: hserr generic events - add entry for the before_exit calls
  • 20da646: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • 9035981: 8321812: Update GC tests to use execute[Limited]TestJava
  • a4d2a5a: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • 201e663: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • fe4a2ae: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • cdfe2f4: 8329840: Fix ZPhysicalMemorySegment::_end type
  • acff39d: 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
  • ... and 17 more: https://git.openjdk.org/jdk21u-dev/compare/035e3144674d494919283941a2e1f3f6dddefaeb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 377f2e538ae0fc94fc5483700a3ae70175017741 8329862: libjli GetApplicationHome cleanups and enhance jli tracing May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 14, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 27, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit 2e327a9.
Since your change was applied there have been 29 commits pushed to the master branch:

  • a0376cd: 8323635: Test gc/g1/TestHumongousAllocConcurrentStart.java fails with -XX:TieredStopAtLevel=3
  • 58c19a6: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 00d3ca2: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 4b1d95c: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
  • d986096: 8330464: hserr generic events - add entry for the before_exit calls
  • 20da646: 8329605: hs errfile generic events - move memory protections and nmethod flushes to separate sections
  • 9035981: 8321812: Update GC tests to use execute[Limited]TestJava
  • a4d2a5a: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • 201e663: 8320681: [macos] Test tools/jpackage/macosx/MacAppStoreJlinkOptionsTest.java timed out on macOS
  • fe4a2ae: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • ... and 19 more: https://git.openjdk.org/jdk21u-dev/compare/035e3144674d494919283941a2e1f3f6dddefaeb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@MBaesken Pushed as commit 2e327a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant