-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin #578
Conversation
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 89 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit 8204bd7.
Your commit was automatically rebased without conflicts. |
I'd like to do the backport because jdk 21 is affected by the issue. The included test hangs without the change.
Besides it will reduce the noise in jck tests we're doing regularily (the test api/java_net/ServerSocket/AcceptInterruptibleTests_PlatformThreads fails sometimes because of the issue).
I'd consider the risk low-medium.
Tested with the included test.
The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/578/head:pull/578
$ git checkout pull/578
Update a local copy of the PR:
$ git checkout pull/578
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/578/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 578
View PR using the GUI difftool:
$ git pr show -t 578
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/578.diff
Webrev
Link to Webrev Comment