8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync

[reinrich]

I would like to backport openjdk/jdk22u@0c57256 to jdk 21 to get clean testing with -XX:+AssertWXAtThreadSync and avoid crashes because the VM is entered with the wrong WXState. The latter is very unlikely nevertheless aiming for clean tests with -XX:+AssertWXAtThreadSync will help to reduce the probability that users are affected by regressions in this area.

Testing:

I've verified every added WXState change if it is actually required.

The fix passed our CI testing with AssertWXAtThreadSync enabled: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8327990 needs maintainer approval

Issue

• JDK-8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync (Bug - P4 - Approved)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/580/head:pull/580
$ git checkout pull/580

Update a local copy of the PR:
$ git checkout pull/580
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/580/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 580

View PR using the GUI difftool:
$ git pr show -t 580

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/580.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

• d7c7326: 8331885: C2: meet between unloaded and speculative types is not symmetric
• 8991255: 8326734: text-decoration applied to lost when mixed with or
• ccee9d0: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present
• 33ba538: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
• ce34aa9: 8332885: Clarify failure_handler self-tests
• a160bd4: 8294148: Support JSplitPane for instructions and test UI
• d275f51: 8316104: Open source several Swing SplitPane and RadioButton related tests
• 9fef7d8: 8325616: JFR ZGC Allocation Stall events should record stack traces
• 24300eb: 8320602: Lock contention in SchemaDVFactory.getInstance()
• d87f5a3: 8329995: Restricted access to /proc can cause JFR initialization to crash
• ... and 79 more: https://git.openjdk.org/jdk21u-dev/compare/6b0467c4736b9bda7fc7650f510754ef91be79f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (71efad6a)

[theRealAph]

I don't understand this comment. Why does issuing a notify need WXWrite?

[reinrich]

The comment is preexisting. Issuing notify doesn't need WXWrite. It needs a thread state transition ThreadInVMfromNative and that transition requires WXWrite.

[theRealAph]

OK. I hate the way this code works, but we need it now.

[reinrich]

/integrate

[openjdk]

Going to push as commit 8da58b9.
Since your change was applied there have been 93 commits pushed to the master branch:

• 8204bd7: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin
• 1bb396f: 8313983: jmod create --target-platform should replace existing ModuleTarget attribute
• f9de294: 8331931: JFR: Avoid loading regex classes during startup
• ace9524: 8329665: fatal error: memory leak: allocating without ResourceMark
• d7c7326: 8331885: C2: meet between unloaded and speculative types is not symmetric
• 8991255: 8326734: text-decoration applied to lost when mixed with or
• ccee9d0: 8332499: Gtest codestrings.validate_vm fail on linux x64 when hsdis is present
• 33ba538: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
• ce34aa9: 8332885: Clarify failure_handler self-tests
• a160bd4: 8294148: Support JSplitPane for instructions and test UI
• ... and 83 more: https://git.openjdk.org/jdk21u-dev/compare/6b0467c4736b9bda7fc7650f510754ef91be79f0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit 8da58b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.