Skip to content

8316138: Add GlobalSign 2 TLS root certificates #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented May 16, 2024

Backport from https://bugs.openjdk.org/browse/JDK-8316138


Progress

  • Change must not contain extraneous whitespace
  • JDK-8316138 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316138: Add GlobalSign 2 TLS root certificates (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/581/head:pull/581
$ git checkout pull/581

Update a local copy of the PR:
$ git checkout pull/581
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 581

View PR using the GUI difftool:
$ git pr show -t 581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/581.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 16, 2024

👋 Welcome back Delawen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 16, 2024

@Delawen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316138: Add GlobalSign 2 TLS root certificates

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2dc90b5: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
  • 9047499: 8331298: avoid alignment checks in UBSAN enabled build
  • f953b8a: 8312218: Print additional debug information when hitting assert(in_hash)
  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4083255440cfbf39b9683ea88a433d71ec6111e7 8316138: Add GlobalSign 2 TLS root certificates May 16, 2024
@openjdk
Copy link

openjdk bot commented May 16, 2024

This backport pull request has now been updated with issue from the original commit.

@Delawen
Copy link
Contributor Author

Delawen commented May 17, 2024

$ make test TEST="jdk_security"  | grep VerifyCACerts
Passed: sun/security/lib/cacerts/VerifyCACerts.java

@Delawen Delawen marked this pull request as ready for review May 17, 2024 10:02
@openjdk
Copy link

openjdk bot commented May 17, 2024

⚠️ @Delawen This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 17, 2024
@mlbridge
Copy link

mlbridge bot commented May 17, 2024

Webrevs

@Delawen
Copy link
Contributor Author

Delawen commented May 17, 2024

/approval JDK-8316138 request Fix Request
This is a backport for https://bugs.openjdk.org/browse/JDK-8316138 It includes two new certificates for cacert. It also updates the test that checks certificates are in place.

@openjdk
Copy link

openjdk bot commented May 17, 2024

@Delawen
JDK-8316138: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 17, 2024
@Delawen
Copy link
Contributor Author

Delawen commented May 17, 2024

@jerboaa Can you review this? There is still a test running in MacOS that failed yesterday, but I think it is not related to my change.

The test that checks the certificates runs properly on my local machine:

$ make test TEST="test/jdk/sun/security/lib/cacerts/VerifyCACerts.java"
Building target 'test' in configuration 'linux-x86_64-server-release'
Test selection 'test/jdk/sun/security/lib/cacerts/VerifyCACerts.java', will run:
* jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java

Running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java'
Passed: sun/security/lib/cacerts/VerifyCACerts.java
Test results: passed: 1
Report written to /home/delawen/git/jdk21u-dev/build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java/html/report.html
Results written to /home/delawen/git/jdk21u-dev/build/linux-x86_64-server-release/test-support/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java
Finished running test 'jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java'
Test report is stored in build/linux-x86_64-server-release/test-results/jtreg_test_jdk_sun_security_lib_cacerts_VerifyCACerts_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/sun/security/lib/cacerts/VerifyCACerts.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-x86_64-server-release'

@jerboaa
Copy link
Contributor

jerboaa commented May 17, 2024

@Delawen Please also run the CA tests in CertPathValidator/certification test. Thanks!

@jerboaa
Copy link
Contributor

jerboaa commented May 17, 2024

/approve yes

@openjdk
Copy link

openjdk bot commented May 17, 2024

@jerboaa
8316138: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 17, 2024
@Delawen
Copy link
Contributor Author

Delawen commented May 17, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@Delawen
Your change (at version 685d56b) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented May 17, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 17, 2024

Going to push as commit ff295b7.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2dc90b5: 8320715: Improve the tests of test/hotspot/jtreg/compiler/intrinsics/float16
  • 9047499: 8331298: avoid alignment checks in UBSAN enabled build
  • f953b8a: 8312218: Print additional debug information when hitting assert(in_hash)
  • 0a2e2e7: 8308144: Uncontrolled memory consumption in SSLFlowDelegate.Reader

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 17, 2024
@openjdk openjdk bot closed this May 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 17, 2024
@openjdk
Copy link

openjdk bot commented May 17, 2024

@jerboaa @Delawen Pushed as commit ff295b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Delawen Delawen deleted the backport-21-DK-8316138 branch May 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants