-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8329109: Threads::print_on() tries to print CPU time for terminated GC threads #585
Conversation
👋 Welcome back lmao! A progress list of the required criteria for merging this PR into |
@mmyxym This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport of fixing crash on Threads::print_on() . Risk is very low. |
@mmyxym, could you please backport this to jdk22u first? Thanks. |
/integrate |
Could committers please help to sponsor? Thanks. |
/sponsor |
Going to push as commit fe4a2ae.
Your commit was automatically rebased without conflicts. |
@RealCLanger @mmyxym Pushed as commit fe4a2ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of fixing crash on Threads::print_on() .
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/585/head:pull/585
$ git checkout pull/585
Update a local copy of the PR:
$ git checkout pull/585
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/585/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 585
View PR using the GUI difftool:
$ git pr show -t 585
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/585.diff
Webrev
Link to Webrev Comment